mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 65306: Updated the way to output error messages in `NetworkCniIsolatorSetup`.
Date Thu, 25 Jan 2018 00:51:34 GMT


> On Jan. 24, 2018, 10:11 a.m., Jie Yu wrote:
> > Looks like this is related to
> > https://github.com/apache/mesos/pull/221
> > 
> > Qian, can you commit the patch by tweaking the PR above and using his name?

The code base of that PR is too old. So I will commit this patch and then close that PR.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65306/#review196093
-----------------------------------------------------------


On Jan. 24, 2018, 9:18 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65306/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2018, 9:18 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-6822
>     https://issues.apache.org/jira/browse/MESOS-6822
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated the way to output error messages in `NetworkCniIsolatorSetup`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp af1d477324e498c2627f6787c8ae7e9e8e3e8fd5

> 
> 
> Diff: https://reviews.apache.org/r/65306/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message