mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@apache.org>
Subject Re: Review Request 65245: Renamed `LOG` by `Stream logs` in Web UI.
Date Thu, 25 Jan 2018 00:39:28 GMT


> On Jan. 22, 2018, 7:33 p.m., Vinod Kone wrote:
> > src/webui/master/static/agent.html
> > Line 45 (original), 45 (patched)
> > <https://reviews.apache.org/r/65245/diff/1/?file=1943087#file1943087line45>
> >
> >     Hmm. This is inconsistent with how we did the stream vs download for sandboxes.
The stream is just a hyper link with the filename followed by a Download button.
> >     
> >     Can we do the same with these logs for consistency? A hyperlink "LOG" that opens
up pailer (which is what it is today) and a "Download" button next to it with some space (like
we did for sandboxes).
> 
> Armand Grillet wrote:
>     I imagine that your comment concerns /r/65246/ where I have changed the front-end
to have a multi-button instead of links.
>     
>     Our sandboxes provide a way to see/download any file in a sandbox (everything is
clickable) whereas the masters/agents UI provide a list of information with only one actionnable
element: getting the logs. The current UI with a single link showing "LOG" in the middle of
a list could be more descriptive and that is why I have changed it.
>     
>     I will discard /r/65245/ and put its content in /r/65246/ and update the UI according
to your comment. I will leave the first screenshot in the "Testing Done" part and add a second
one with the UI after the patch update so that you and Benjamin can decide.

SGTM.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65245/#review195926
-----------------------------------------------------------


On Jan. 20, 2018, 4:14 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65245/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2018, 4:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-8454
>     https://issues.apache.org/jira/browse/MESOS-8454
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The home and agents Web UI are now more descriptive. The name of the
> functions called when clicking these two links have also been updated.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/agent.html 908d01d1d28f2a4fc595b581fa16515c5be1410a 
>   src/webui/master/static/home.html df3eef61eb9564dbdfc3d138ecfd18e85f747f11 
>   src/webui/master/static/js/controllers.js 59665869dbea77c00740e42f2590473181dfe2fe

> 
> 
> Diff: https://reviews.apache.org/r/65245/diff/1/
> 
> 
> Testing
> -------
> 
> Checked manually that the feature was still working on the home and agents endpoints.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message