mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 65261: Fixed connection refused error in IOSwitchboard for unix socket.
Date Thu, 25 Jan 2018 00:30:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65261/#review196185
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/io/switchboard.cpp
Lines 839-840 (original), 840-847 (patched)
<https://reviews.apache.org/r/65261/#comment275730>

    Let's do the following for brevity and clarity:
    ```
    const string socketPath = address.isSome()
      ? address->path()
      : getContainerIOSwitchboardSocketProvisionalPath(
            flags.runtime_dir, containerId);
    ```



src/slave/containerizer/mesos/io/switchboard.cpp
Lines 1054 (patched)
<https://reviews.apache.org/r/65261/#comment275727>

    const string?



src/slave/containerizer/mesos/io/switchboard.cpp
Lines 1078 (patched)
<https://reviews.apache.org/r/65261/#comment275728>

    s/"to '"/" to '"



src/slave/containerizer/mesos/paths.hpp
Lines 147 (patched)
<https://reviews.apache.org/r/65261/#comment275721>

    Add "See comments in IOSwitchboardServer::create()".



src/slave/containerizer/mesos/paths.hpp
Lines 152 (patched)
<https://reviews.apache.org/r/65261/#comment275722>

    Add "See comments in IOSwitchboardServer::create()".


- Alexander Rukletsov


On Jan. 22, 2018, 1 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65261/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2018, 1 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Kevin Klues.
> 
> 
> Bugs: MESOS-7742
>     https://issues.apache.org/jira/browse/MESOS-7742
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Once IOSwitchboard's unix socket appears in the file system, the agent
> can try to connect to it. If the agent attempts to connect to the
> socket before `listen` has been called, then it gets connection refused
> error. To address this, we initialize a unix socket using a provisional
> path and rename it after `listen` has been called.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp 45b615be60af9af839309011eea85912c01ff451

>   src/slave/containerizer/mesos/paths.hpp 65830a153f765c74bb0399bca9b2941390eeb531 
>   src/slave/containerizer/mesos/paths.cpp 0df4cf5f50aee94a2758ce885389fb488a85fdbd 
> 
> 
> Diff: https://reviews.apache.org/r/65261/diff/2/
> 
> 
> Testing
> -------
> 
> make check (Fedora 25)
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message