mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 65326: Fixed conversion warning.
Date Wed, 24 Jan 2018 23:15:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65326/#review196178
-----------------------------------------------------------


Ship it!




I am not a native speaker, but maybe we could make the commit message clearer, e.g., something
along the lines of

    Fixed a conversion warning.

    A "possible loss of data" warning was triggered with MSVC since
    `process.run(int)` implicitly converted an `unsigned` argument to
    `int`. This patch fixes the type of the passed values.

- Benjamin Bannier


On Jan. 24, 2018, 11:16 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65326/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2018, 11:16 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> A "possible loss of data" warning was introduced because `process.run()`
> implicitly converts to an `int`. Since we have a finite set of ints,
> we can just use the `int` type.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/benchmarks.cpp 10fd492951fb1133d057eb3576f93a5f10e178f3

> 
> 
> Diff: https://reviews.apache.org/r/65326/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message