mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 65326: Fixed conversion warning.
Date Wed, 24 Jan 2018 23:08:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65326/#review196177
-----------------------------------------------------------



PASS: Mesos patch 65326 was successfully built and tested.

Reviews applied: `['65326']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65326

- Mesos Reviewbot Windows


On Jan. 24, 2018, 2:16 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65326/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2018, 2:16 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> A "possible loss of data" warning was introduced because `process.run()`
> implicitly converts to an `int`. Since we have a finite set of ints,
> we can just use the `int` type.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/benchmarks.cpp 10fd492951fb1133d057eb3576f93a5f10e178f3

> 
> 
> Diff: https://reviews.apache.org/r/65326/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message