mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 65316: Added test for delayed authorization during operator events.
Date Wed, 24 Jan 2018 20:04:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65316/
-----------------------------------------------------------

(Updated Jan. 24, 2018, 8:04 p.m.)


Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Vinod Kone.


Changes
-------

Addressed Gaston's comment.


Bugs: MESOS-8469
    https://issues.apache.org/jira/browse/MESOS-8469


Repository: mesos


Description (updated)
-------

Until the fix for MESOS-8469, it was possible for the master
operator event stream to drop events, if event-related state in
the master changed in between asynchronous calls.

This patch adds `MasterAPITest.EventAuthorizationDelayed` to
verify the fix for that issue.


Diffs (updated)
-----

  src/tests/api_tests.cpp bdacc30be4dc8656a41a0c47d0e350d48e59ad94 


Diff: https://reviews.apache.org/r/65316/diff/3/

Changes: https://reviews.apache.org/r/65316/diff/2-3/


Testing
-------

Confirmed that the test fails without the fix for MESOS-8469.

When the fix is included, the test passes. Successfully ran `bin/mesos-tests.sh --gtest_filter="ContentType/MasterAPITest.EventAuthorizationDelayed*"
--gtest_repeat=1000 --gtest_break_on_failure` to rule out any flakiness.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message