mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 65261: Fixed connection refused error in IOSwitchboard for unix socket.
Date Wed, 24 Jan 2018 18:19:11 GMT


> On Jan. 23, 2018, 3:12 p.m., Alexander Rukletsov wrote:
> > src/slave/containerizer/mesos/paths.hpp
> > Lines 147-149 (patched)
> > <https://reviews.apache.org/r/65261/diff/1/?file=1943242#file1943242line147>
> >
> >     Let's find a more descriptive word for this, "temp" can mean anything. We want
to say, that this is a path that exists before the socket is being listend on, or, in other
words, fully initialized.
> >     
> >     How about "prefatory" or "preparatory". Maybe "prep" is sufficient. Can you
please consult a native English speaker?

Renamed "temporary" to "provisional".


- Andrei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65261/#review196009
-----------------------------------------------------------


On Jan. 22, 2018, 1 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65261/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2018, 1 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Kevin Klues.
> 
> 
> Bugs: MESOS-7742
>     https://issues.apache.org/jira/browse/MESOS-7742
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Once IOSwitchboard's unix socket appears in the file system, the agent
> can try to connect to it. If the agent attempts to connect to the
> socket before `listen` has been called, then it gets connection refused
> error. To address this, we initialize a unix socket using a provisional
> path and rename it after `listen` has been called.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp 45b615be60af9af839309011eea85912c01ff451

>   src/slave/containerizer/mesos/paths.hpp 65830a153f765c74bb0399bca9b2941390eeb531 
>   src/slave/containerizer/mesos/paths.cpp 0df4cf5f50aee94a2758ce885389fb488a85fdbd 
> 
> 
> Diff: https://reviews.apache.org/r/65261/diff/2/
> 
> 
> Testing
> -------
> 
> make check (Fedora 25)
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message