mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 65290: Reverted usage of the -isystem flag for includes (3/3).
Date Wed, 24 Jan 2018 17:17:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65290/#review196141
-----------------------------------------------------------



FAIL: Mesos tests failed to build.

Reviews applied: `['65308', '62447', '65289', '65290']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65290

Relevant logs:

- [mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65290/logs/mesos-tests-build-cmake-stdout.log):

```
  D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1799): warning C4996:
'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable
deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1814): warning C4996:
'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable
deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1818): warning C4996:
'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable
deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1826): warning C4996:
'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable
deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(2363): warning C4996:
'strdup': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant
name: _strdup. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(2377): warning C4996:
'stricmp': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant
name: _stricmp. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\seterror.c(189): warning
C4996: 'strerror': This function or variable may be unsafe. Consider using strerror_s instead.
To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(236): warning
C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead.
To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(241): warning
C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead.
To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(253): warning
C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead.
To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(278): warning
C4996: 'stricmp': The POSIX name for this item is deprecated. Instead, use the ISO C and C++
conformant name: _stricmp. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(289): warning
C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead.
To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(290): warning
C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead.
To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(293): warning
C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead.
To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\plugins\cram.c(138): warning
C4477: 'snprintf' : format string '%lu' requires an argument of type 'unsigned long', but
variadic argument 1 has type 'time_t' [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\plugins\cram.c(157): warning
C4996: 'sprintf': This function or variable may be unsafe. Consider using sprintf_s instead.
To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\plugins\cram.c(293): warning
C4996: 'strncpy': This function or variable may be unsafe. Consider using strncpy_s instead.
To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]


"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\mesos.vcxproj" (default target) (12) ->
(ClCompile target) -> 
  D:\DCOS\mesos\mesos\src\executor\executor.cpp(233): error C2039: 'eraseenv': is not a member
of 'os' [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\executor\executor.cpp(233): error C3861: 'eraseenv': identifier
not found [D:\DCOS\mesos\src\mesos.vcxproj]

    112 Warning(s)
    2 Error(s)

Time Elapsed 00:03:20.59
```

- [mesos-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65290/logs/mesos-tests-CMakeOutput.log):

```
  Creating directory "cmTC_46ba5.dir\Debug\".

  Creating directory "D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".

  Creating directory "cmTC_46ba5.dir\Debug\cmTC_46ba5.tlog\".

InitializeBuildStatus:

  Creating "cmTC_46ba5.dir\Debug\cmTC_46ba5.tlog\unsuccessfulbuild" because "AlwaysCreate"
was specified.

ClCompile:

  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe
/c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11
/D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope
/Zc:inline /GR /Fo"cmTC_46ba5.dir\Debug\" /Fd"cmTC_46ba5.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue
D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx

  Microsoft (R) C/C++ Optimizing Compiler Version 19.12.25830.2 for x64

  Copyright (C) Microsoft Corporation.  All rights reserved.

  

  cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11
/D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope
/Zc:inline /GR /Fo"cmTC_46ba5.dir\Debug\" /Fd"cmTC_46ba5.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue
D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx

  src.cxx

  

Link:

  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\link.exe
/ERRORREPORT:QUEUE /OUT:"D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_46ba5.exe" /INCREMENTAL
/NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib
uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'"
/manifest:embed /DEBUG /PDB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_46ba5.pdb" /SUBSYSTEM:CONSOLE
/TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_46ba5.lib"
/MACHINE:X64  /machine:x64 cmTC_46ba5.dir\Debug\src.obj

  cmTC_46ba5.vcxproj -> D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_46ba5.exe

FinalizeBuildStatus:

  Deleting file "cmTC_46ba5.dir\Debug\cmTC_46ba5.tlog\unsuccessfulbuild".

  Touching "cmTC_46ba5.dir\Debug\cmTC_46ba5.tlog\cmTC_46ba5.lastbuildstate".

Done Building Project "D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_46ba5.vcxproj" (default targets).



Build succeeded.

    0 Warning(s)

    0 Error(s)



Time Elapsed 00:00:01.28


Source file was:
int main() { return 0; }
```

- [mesos-tests-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65290/logs/mesos-tests-CMakeError.log):

```
PrepareForBuild:

  Creating directory "cmTC_694e1.dir\Debug\".

  Creating directory "D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".

  Creating directory "cmTC_694e1.dir\Debug\cmTC_694e1.tlog\".

InitializeBuildStatus:

  Creating "cmTC_694e1.dir\Debug\cmTC_694e1.tlog\unsuccessfulbuild" because "AlwaysCreate"
was specified.

ClCompile:

  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe
/c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE
/D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t
/Zc:forScope /Zc:inline /Fo"cmTC_694e1.dir\Debug\" /Fd"cmTC_694e1.dir\Debug\vc141.pdb" /Gd
/TC /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c

  Microsoft (R) C/C++ Optimizing Compiler Version 19.12.25830.2 for x64

  Copyright (C) Microsoft Corporation.  All rights reserved.

  

  cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D
_UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise
/Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_694e1.dir\Debug\" /Fd"cmTC_694e1.dir\Debug\vc141.pdb"
/Gd /TC /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c

  CheckIncludeFile.c

  

D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include
file: 'pthread.h': No such file or directory [D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_694e1.vcxproj]

Done Building Project "D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_694e1.vcxproj" (default targets)
-- FAILED.



Build FAILED.



"D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_694e1.vcxproj" (default target) (1) ->

(ClCompile target) -> 

  D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open
include file: 'pthread.h': No such file or directory [D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_694e1.vcxproj]



    0 Warning(s)

    1 Error(s)



Time Elapsed 00:00:00.65



```

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:23 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65290/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2018, 4:23 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This flag break the build of mesos against system libraries
> installed under /usr, because it generates a command line
> of `-isystem /usr/include`, which is explicitly not supported
> by gcc. See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/Makefile.am 313e4fef61ad73276a5636c31a009f813e37263b 
>   3rdparty/stout/configure.ac 6db22877ca518ff47853f9c49e30d78f5b8c240d 
> 
> 
> Diff: https://reviews.apache.org/r/65290/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> Internal CI: https://jenkins.mesosphere.com/service/jenkins/view/Mesos/job/mesos/job/Mesos_CI-build/2700/
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message