mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 63366: Added jemalloc release tarball and build rules.
Date Wed, 24 Jan 2018 16:42:23 GMT


> On Nov. 10, 2017, 3:52 p.m., Alexander Rukletsov wrote:
> > configure.ac
> > Lines 213 (patched)
> > <https://reviews.apache.org/r/63366/diff/1/?file=1870301#file1870301line213>
> >
> >     Maybe "jemalloc-allocator"? Or "bundled-jemalloc"?

I think 'jemalloc-allocator' sounds good, changed.


> On Nov. 10, 2017, 3:52 p.m., Alexander Rukletsov wrote:
> > configure.ac
> > Lines 1144-1147 (original), 1206-1209 (patched)
> > <https://reviews.apache.org/r/63366/diff/1/?file=1870301#file1870301line1206>
> >
> >     Is this change on purpose?

Nope. (Actually, I don't even know how to do this accidentally)


- Benno


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63366/#review190721
-----------------------------------------------------------


On Jan. 24, 2018, 4:37 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63366/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2018, 4:37 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This allows building and linking against the bundled
> version of jemalloc when the --enable-jemalloc-allocator
> configuration flag is specified.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 579aed83fc5c9cee17cf9b4b289a91705f64ceda 
>   3rdparty/Makefile.am f4cb731198e271b967b920235ed2785e9296f9e1 
>   3rdparty/cmake/Versions.cmake 94b0d8048412e00e2480f45e7ce4e6494da4bd5d 
>   3rdparty/jemalloc-5.0.1.tar.bz2 PRE-CREATION 
>   3rdparty/libprocess/src/CMakeLists.txt f002c157dc2ca64da66bc4e61f5095f2b533ae1f 
>   3rdparty/versions.am 3e008d5a7bdc029de23950463c295b968b3280c8 
>   cmake/CompilationConfigure.cmake 50cddf9476c8c5196c4824a7b060c2680a96b277 
>   configure.ac fc34ff44a20cc34c8ceeca0d9afac2fab49b86a6 
>   src/Makefile.am fe8f689c6b82a88e6e114d5d2082183b3cf4ed54 
>   src/master/CMakeLists.txt ec552110509d17628107f4ad98f2d04675ed3ce3 
>   src/slave/CMakeLists.txt 943e8f523f867e3dd4030f78eca7830500578faf 
> 
> 
> Diff: https://reviews.apache.org/r/63366/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message