mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 65308: Fix shadowed sign-compare and enum-compare warnings in tests.
Date Wed, 24 Jan 2018 16:17:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65308/
-----------------------------------------------------------

(Updated Jan. 24, 2018, 4:17 p.m.)


Review request for mesos and Benjamin Bannier.


Summary (updated)
-----------------

Fix shadowed sign-compare and enum-compare warnings in tests.


Bugs: MESOS-8482
    https://issues.apache.org/jira/browse/MESOS-8482


Repository: mesos


Description (updated)
-------

These warnings were hidden due to the usage of the '-isystem'
flag to include the gtest headers.


Diffs (updated)
-----

  src/tests/api_tests.cpp bdacc30be4dc8656a41a0c47d0e350d48e59ad94 
  src/tests/check_tests.cpp 0163e3a2fe9d28d0579fb454f2f1c1912c57b0f8 
  src/tests/containerizer/cni_isolator_tests.cpp 364e2e30a76daff7eaa2b2acaada05b4124ef7a4

  src/tests/containerizer/mesos_containerizer_tests.cpp 0729464a7a9b290c8634536e58909f9b38b58a9c

  src/tests/containerizer/nested_mesos_containerizer_tests.cpp db60bfb143765be6d3eeab6a54663774ea14b8fa

  src/tests/default_executor_tests.cpp f8ae0379998898aefcac930f410f67cdb2c08f66 
  src/tests/disk_quota_tests.cpp 4e25e32bf784ea818e18497fe3ebc9f94c5861ff 
  src/tests/fault_tolerance_tests.cpp 2dfd00938d0d46135ece77cec45a8fd28867b055 
  src/tests/hierarchical_allocator_tests.cpp 9bc939d8be4d029ef9ca996ce2a074e3af512f6f 
  src/tests/master_slave_reconciliation_tests.cpp 26ff6893a9d6bbc34bcdcad9c9304f75ab283d9f

  src/tests/master_tests.cpp d01f3fbdd688ddd31fb0c777f973928f5b5fa5e7 
  src/tests/master_validation_tests.cpp ed8f9bd31828035c19e5a38d3ad459649027b5b6 
  src/tests/oversubscription_tests.cpp e6139b0d353ad268ae2d09d47c43ff27a4af4c1e 
  src/tests/slave_tests.cpp 3a6546b07ac202c461b5c5e8bfcf1eb4f3fe6b4e 
  src/tests/sorter_tests.cpp 6ca724d35da13bd1ceb19f87af9a7950a5a982cf 


Diff: https://reviews.apache.org/r/65308/diff/2/

Changes: https://reviews.apache.org/r/65308/diff/1-2/


Testing
-------


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message