mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 63367: Added overloads for strings::startsWith and strings::endsWith().
Date Wed, 24 Jan 2018 15:12:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63367/
-----------------------------------------------------------

(Updated Jan. 24, 2018, 3:12 p.m.)


Review request for mesos, Alexander Rukletsov and Benjamin Mahler.


Changes
-------

Add symmetric overload for `strings::startsWith()`


Summary (updated)
-----------------

Added overloads for strings::startsWith and strings::endsWith().


Repository: mesos


Description (updated)
-------

This saves an unnecessary memory allocation when
testing if a string starts or ends with a string literal,
which accounts for almost all usages of these functions
in Mesos and in libprocess.


Diffs (updated)
-----

  3rdparty/stout/include/stout/strings.hpp 067a7923c02342bccd9be1136a981fd6b0e0e9b4 
  3rdparty/stout/tests/strings_tests.cpp 395540aad88c76a66a43a54edfe9ca1a2d46d3b4 


Diff: https://reviews.apache.org/r/63367/diff/3/

Changes: https://reviews.apache.org/r/63367/diff/2-3/


Testing
-------


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message