mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 62447: Reverted usage of the -isystem flag for includes (1/3).
Date Wed, 24 Jan 2018 14:57:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62447/
-----------------------------------------------------------

(Updated Jan. 24, 2018, 2:57 p.m.)


Review request for mesos, Benjamin Bannier and Till Toenshoff.


Summary (updated)
-----------------

Reverted usage of the -isystem flag for includes (1/3).


Repository: mesos


Description (updated)
-------

This flag break the build of mesos against system libraries
installed under /usr, because it generates a command line
of `-isystem /usr/include`, which is explicitly not supported
by gcc. See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129


Diffs (updated)
-----

  3rdparty/CMakeLists.txt 579aed83fc5c9cee17cf9b4b289a91705f64ceda 
  configure.ac fc34ff44a20cc34c8ceeca0d9afac2fab49b86a6 
  m4/libnl3.m4 238ac6e01ea6d1897bd307a84ca522250f34c0fa 
  src/Makefile.am fe8f689c6b82a88e6e114d5d2082183b3cf4ed54 


Diff: https://reviews.apache.org/r/62447/diff/4/

Changes: https://reviews.apache.org/r/62447/diff/3-4/


Testing
-------


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message