mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <>
Subject Re: Review Request 65278: Fixed a race in the test `ROOT_MultiTaskgroupSharePidNamespace`.
Date Wed, 24 Jan 2018 06:23:56 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 24, 2018, 2:23 p.m.)

Review request for mesos and Gilbert Song.


Addressed comments.

Bugs: MESOS-8305

Repository: mesos


In the test `DefaultExecutorTest.ROOT_MultiTaskgroupSharePidNamespace`,
we read the file `ns` in each of the two task's sandbox and check if
their contents (the pid namespace of the task itself) are same. However
it is possible we do the read for the second task after that file is
created but before it is written, i.e., the content we read from the
`ns` file of the second task would be empty which will cause the check

In this patch, we read the file `ns` for each task in a while loop, and
only break from the loop when both task's files are not empty.

Diffs (updated)

  src/tests/default_executor_tests.cpp 065eae665db08b39aef70325cebc2753beb30d96 




Manually ran this test repeatedly (100 times).


Qian Zhang

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message