mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 65277: Logged pid of launched containers in the linux launcher.
Date Tue, 23 Jan 2018 02:10:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65277/#review195964
-----------------------------------------------------------



Why does this need to be in a hook gated by the parent<->child synchronization? Are
you trying to improve the likelihood that it gets logged? It seems simpler to just log it
after the fork?

- Benjamin Mahler


On Jan. 23, 2018, 1:58 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65277/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2018, 1:58 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Logged pid of launched containers in the linux launcher.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/linux_launcher.cpp c2e319894874e628beda6dc305462af0c274fd7b

> 
> 
> Diff: https://reviews.apache.org/r/65277/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message