mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 65253: Avoided dropping events on the master operator API stream.
Date Mon, 22 Jan 2018 23:07:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65253/#review195949
-----------------------------------------------------------


Fix it, then Ship it!




Nice to see performance improvements here as well :)

In the summary, could you say something like "Fixed ..." to clarify that it's a bug fix? Also,
maybe we could include in the description the task added/updated scenarios?


src/master/master.hpp
Lines 1997-2001 (original), 1997-2004 (patched)
<https://reviews.apache.org/r/65253/#comment275380>

    Per offline discussion, maybe a TODO here for overloads?



src/master/master.cpp
Lines 11196-11199 (patched)
<https://reviews.apache.org/r/65253/#comment275383>

    Maybe we should put the breaks here to prevent an accident later if someone adds the AGENT_ADDED
case?



src/master/master.cpp
Lines 11200-11201 (patched)
<https://reviews.apache.org/r/65253/#comment275384>

    No default due to MESOS-2664.



src/master/master.cpp
Lines 11200-11201 (patched)
<https://reviews.apache.org/r/65253/#comment275385>

    No defaults for enums, due to MESOS-2664.
    
    Ditto below.



src/master/master.cpp
Lines 11200-11201 (patched)
<https://reviews.apache.org/r/65253/#comment275387>

    No defaults for enums, due to MESOS-2664.
    
    Ditto below.



src/master/master.cpp
Lines 11205 (patched)
<https://reviews.apache.org/r/65253/#comment275381>

    std::move(event)?



src/master/master.cpp
Lines 11346-11348 (original), 11379-11381 (patched)
<https://reviews.apache.org/r/65253/#comment275386>

    No default due to MESOS-2664.


- Benjamin Mahler


On Jan. 22, 2018, 9:10 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65253/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2018, 9:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Benjamin Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-8469
>     https://issues.apache.org/jira/browse/MESOS-8469
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The master's `Subscribers::send()` call path previously accessed
> event-related master state after an asynchronous call. Thus, if
> that state changed after the call to `Subscribers::send()` but
> before the event was actually sent, messages could be dropped.
> 
> This patch updates that call path to capture a shared copy of
> event-related metadata so that the asynchronous calls have a
> consistent view of the master's state at the time of the event.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 05136781b6b1539f37c283e8127e4bafb187a0d1 
>   src/master/master.cpp 3af96b1d2024ab1b951537ebc6bbc225cfa9cc88 
> 
> 
> Diff: https://reviews.apache.org/r/65253/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message