mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 63862: Windows: Ported docker_tests.cpp.
Date Mon, 22 Jan 2018 19:17:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review195528
-----------------------------------------------------------




src/tests/containerizer/docker_tests.cpp
Lines 61-62 (patched)
<https://reviews.apache.org/r/63862/#comment275304>

    Is it possible to run earlier/later versions of images?
    
    i.e. If the base OS is 1710 (or later) can it still run this image?  Or if the base OS
is 1708 (or earlier) will the image definitely fail?



src/tests/containerizer/docker_tests.cpp
Lines 127 (patched)
<https://reviews.apache.org/r/63862/#comment274732>

    Avoid using `CHECK` which can prematurely stop the test suite.  Try `ASSERT_TRUE(future.ready());`.



src/tests/containerizer/docker_tests.cpp
Lines 155-163 (patched)
<https://reviews.apache.org/r/63862/#comment275311>

    It doesn't really make a difference to the Linux tests whether they mount a file or directory.
 We might as well make them all mount a directory; and thereby remove this helper.



src/tests/containerizer/docker_tests.cpp
Lines 580-582 (original), 712-715 (patched)
<https://reviews.apache.org/r/63862/#comment275313>

    Do you know if this will _never_ be supported?
    In which case, we should get rid of the `_TEMP_DISABLED_ON_WINDOWS` and make the disabling
more permanent.


- Joseph Wu


On Jan. 5, 2018, 10:33 a.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2018, 10:33 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman,
Jie Yu, John Kordich, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-7342
>     https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
>   - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
>     sandbox).
>   - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
>   - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_tests.cpp 0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57 
> 
> 
> Diff: https://reviews.apache.org/r/63862/diff/5/
> 
> 
> Testing
> -------
> 
> Windows mesos-test:
> [==========] 754 tests from 77 test cases ran. (270586 ms total)
> [  PASSED  ] 754 tests.
> 
> 
> Windows DockerTest only:
> [==========] 11 tests from 1 test case ran. (85617 ms total)
> [  PASSED  ] 11 tests.
> 
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia GPU):
> [==========] 12 tests from 1 test case ran. (12413 ms total)
> [  PASSED  ] 12 tests.
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message