mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 65045: Tested correct operation handling during master failover.
Date Mon, 22 Jan 2018 18:58:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/#review195918
-----------------------------------------------------------



This test emitted some gmock warnings for me. Could you get rid of these?

    GMOCK WARNING:
    Uninteresting mock function call - returning directly.
        Function call: registered(0x7fff12024248, @0x7fe5e0006de0 622fd6fc-f57a-4657-8d79-d30efb8f8e66-0000,
@0x7fe5e0006940 id: "622fd6fc-f57a-4657-8d79-d30efb8f8e66"
    Ip: 3492307904
    Port: 37105
    Pid: "master@192.99.40.208:37105"
    Hostname: "gru1.hw.ca1.mesosphere.com"
    Version: "1.6.0"
    Address {
      hostname: "gru1.hw.ca1.mesosphere.com"
      ip: "192.99.40.208"
      port: 37105
    }
    Capabilities {
      type: AGENT_UPDATE
    }
    )
    NOTE: You can safely ignore the above warning unless this call should not happen.  Do
not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.
 See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect
for details.
    
    GMOCK WARNING:
    Uninteresting mock function call - returning directly.
        Function call: disconnected(0x7fff12024248)
    NOTE: You can safely ignore the above warning unless this call should not happen.  Do
not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.
 See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect
for details.
    
    GMOCK WARNING:
    Uninteresting mock function call - returning directly.
        Function call: registered(0x7fff12024248, @0x7fe5ec001740 622fd6fc-f57a-4657-8d79-d30efb8f8e66-0000,
@0x7fe5ec002130 id: "f935fe81-68e3-4dbd-b258-6c216e9bb4c7"
    Ip: 3492307904
    Port: 37105
    Pid: "master@192.99.40.208:37105"
    Hostname: "gru1.hw.ca1.mesosphere.com"
    Version: "1.6.0"
    Address {
      hostname: "gru1.hw.ca1.mesosphere.com"
      ip: "192.99.40.208"
      port: 37105
    }
    Capabilities {
      type: AGENT_UPDATE
    }
    )
    NOTE: You can safely ignore the above warning unless this call should not happen.  Do
not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.
 See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect
for details.
    
    GMOCK WARNING:
    Uninteresting mock function call - returning directly.
        Function call: offerRescinded(0x7fff12024248, @0x7fe5ec0015a8 f935fe81-68e3-4dbd-b258-6c216e9bb4c7-O0)
    NOTE: You can safely ignore the above warning unless this call should not happen.  Do
not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.
 See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect
for details.
    ../src/tests/master_tests.cpp:8916: Failure


src/tests/master_tests.cpp
Lines 8804 (patched)
<https://reviews.apache.org/r/65045/#comment275303>

    nit: get rid of this line.



src/tests/master_tests.cpp
Lines 8872 (patched)
<https://reviews.apache.org/r/65045/#comment275305>

    Since with only assertions it becomes hard to recognize what is being tested, let's expect
here.



src/tests/master_tests.cpp
Lines 8942 (patched)
<https://reviews.apache.org/r/65045/#comment275306>

    We could expect here for self-documentation.


- Benjamin Bannier


On Jan. 18, 2018, 3:11 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65045/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2018, 3:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8424
>     https://issues.apache.org/jira/browse/MESOS-8424
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Tested correct operation handling during master failover.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp d01f3fbdd688ddd31fb0c777f973928f5b5fa5e7 
> 
> 
> Diff: https://reviews.apache.org/r/65045/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message