mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Review Request 65261: Fixed connection refused error in IOSwitchboard for unix socket.
Date Mon, 22 Jan 2018 13:00:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65261/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Jie Yu, and Kevin Klues.


Bugs: MESOS-7742
    https://issues.apache.org/jira/browse/MESOS-7742


Repository: mesos


Description
-------

Once IOSwitchboard's unix socket appears in the file system, the agent
can try to connect to it. If the agent attempts to connect to the
socket before `listen` has been called, then it gets connection refused
error. To address this, create a unix socket using a temporary name,
then initialize it, then rename the socket with the original path.


Diffs
-----

  src/slave/containerizer/mesos/io/switchboard.cpp 45b615be60af9af839309011eea85912c01ff451

  src/slave/containerizer/mesos/paths.hpp 65830a153f765c74bb0399bca9b2941390eeb531 
  src/slave/containerizer/mesos/paths.cpp 0df4cf5f50aee94a2758ce885389fb488a85fdbd 


Diff: https://reviews.apache.org/r/65261/diff/1/


Testing
-------

make check (Fedora 25)
internal CI


Thanks,

Andrei Budnik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message