mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 65182: Tested that agent resends unacknowledged op status updates on recovery.
Date Fri, 19 Jan 2018 22:38:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65182/#review195857
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/storage_local_resource_provider_tests.cpp
Lines 1847 (patched)
<https://reviews.apache.org/r/65182/#comment275194>

    Ditto here regarding the decline, as in parent review.



src/tests/storage_local_resource_provider_tests.cpp
Lines 1921-1923 (patched)
<https://reviews.apache.org/r/65182/#comment275195>

    Hmm this seems potentially flaky. What if this expectation is registered before the update
acknowledgement is processed? To avoid flakiness, we should probably capture the ACK and await
on it before we make this call.


- Greg Mann


On Jan. 16, 2018, 9 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65182/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2018, 9 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
> 
> 
> Bugs: MESOS-8362
>     https://issues.apache.org/jira/browse/MESOS-8362
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a test to verify that the agent resends unacknowledged
> operation status updates after a recovery.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp bbfe95e9818f25fdd5405db3ad2fe355e023f743

> 
> 
> Diff: https://reviews.apache.org/r/65182/diff/4/
> 
> 
> Testing
> -------
> 
> `GLOG_v=1 sudo bin/mesos-tests.sh --gtest_filter='StorageLocalResourceProviderTest.ROOT_RetryOperationStatusUpdateAfterRecovery'
--verbose --gtest_repeat=1000 --gtest_break_on_failure` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message