mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaston Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 65057: Tested that op status updates dropped en route to master are resent.
Date Fri, 19 Jan 2018 21:53:00 GMT


> On Jan. 18, 2018, 11:20 a.m., Greg Mann wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Lines 2226 (patched)
> > <https://reviews.apache.org/r/65057/diff/4/?file=1941294#file1941294line2226>
> >
> >     Do we need this, or just being careful? If it is needed, it might not be if
we add a long filter to the accept call.

At the end of the test I do the following in order to make sure that the agent doesn't resend
the status update once it has been acknowledged:

```
  // The master acknowledged the operation status update, so the SLRP shouldn't
  // send further operation status updates.
  EXPECT_NO_FUTURE_PROTOBUFS(UpdateOperationStatusMessage(), _, _);

  Clock::advance(slave::STATUS_UPDATE_RETRY_INTERVAL_MIN);
  Clock::settle();
```

That happens after the master has received the status update, so it can (and will) send another
offer.

I moved the decline to that part and added a comment.


- Gaston


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65057/#review195745
-----------------------------------------------------------


On Jan. 18, 2018, 6:19 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65057/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2018, 6:19 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu.
> 
> 
> Bugs: MESOS-8363 and MESOS-8420
>     https://issues.apache.org/jira/browse/MESOS-8363
>     https://issues.apache.org/jira/browse/MESOS-8420
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds
> `StorageLocalResourceProviderTest.ROOT_RetryOperationStatusUpdate` that
> verifies that operation status updates are resent to the master after
> being dropped en route to it.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp bbfe95e9818f25fdd5405db3ad2fe355e023f743

> 
> 
> Diff: https://reviews.apache.org/r/65057/diff/5/
> 
> 
> Testing
> -------
> 
> `sudo bin/mesos-tests.sh --gtest_filter='StorageLocalResourceProviderTest.ROOT_RetryOperationStatusUpdate'
--gtest_repeat=100 --gtest_break_on_failure` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message