mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 65231: Fixed detaching task volume directories of destroyed frameworks.
Date Fri, 19 Jan 2018 02:20:58 GMT


> On Jan. 19, 2018, 1:36 a.m., Vinod Kone wrote:
> > src/slave/slave.cpp
> > Lines 1029 (patched)
> > <https://reviews.apache.org/r/65231/diff/3/?file=1942241#file1942241line1029>
> >
> >     Custom executors satisfy this check so it's not fool proof. Lets pass `ExecutorInfo`
here and check the type instead.

I don't like the fact that we pass in the `ExecutorInfo` but don't use it at all in the functions,
but I can live with it so I'll do it.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65231/#review195764
-----------------------------------------------------------


On Jan. 19, 2018, 1:25 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65231/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2018, 1:25 a.m.)
> 
> 
> Review request for mesos, Michael Park, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-8460
>     https://issues.apache.org/jira/browse/MESOS-8460
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed detaching task volume directories of destroyed frameworks.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp a07f046c7ed980bed3e3d0d2780295727b87ee44 
>   src/slave/slave.cpp 1672c06894c25e7120bb8a1da15f7d6432eb5954 
> 
> 
> Diff: https://reviews.apache.org/r/65231/diff/3/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message