mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 65212: Updated `mesos-tidy` docker build setup for benchmarks.
Date Thu, 18 Jan 2018 15:13:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65212/#review195723
-----------------------------------------------------------



PASS: Mesos patch 65212 was successfully built and tested.

Reviews applied: `['65212']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65212

- Mesos Reviewbot Windows


On Jan. 18, 2018, 1:24 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65212/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2018, 1:24 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the `mesos-tidy` docker build setup to generate
> `benchmarks.pb.h` needed by the libprocess benchmark files added as
> part of `eb901173b8aa43b9fd1ab0f727ff5187982c4449`.
> 
> We also reorder the targets to be build in the script so that all
> proto targets are located close to each other and after manually
> triggered 3rdparty dependencies (like e.g., protobuf). This should
> reduce redudant build invocations.
> 
> 
> Diffs
> -----
> 
>   support/mesos-tidy/entrypoint.sh dd83d66f48968bce652bc78ccf2d807949f1725b 
> 
> 
> Diff: https://reviews.apache.org/r/65212/diff/2/
> 
> 
> Testing
> -------
> 
> Tested with a custom docker image and `support/mesos-tidy.sh` pointing to it.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message