mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 65212: Updated `mesos-tidy` docker build setup for benchmarks.
Date Thu, 18 Jan 2018 13:24:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65212/
-----------------------------------------------------------

(Updated Jan. 18, 2018, 2:24 p.m.)


Review request for mesos and Michael Park.


Summary (updated)
-----------------

Updated `mesos-tidy` docker build setup for benchmarks.


Repository: mesos


Description
-------

This patch updates the `mesos-tidy` docker build setup to generate
`benchmarks.pb.h` needed by the libprocess benchmark files added as
part of `eb901173b8aa43b9fd1ab0f727ff5187982c4449`.

We also reorder the targets to be build in the script so that all
proto targets are located close to each other and after manually
triggered 3rdparty dependencies (like e.g., protobuf). This should
reduce redudant build invocations.


Diffs (updated)
-----

  support/mesos-tidy/entrypoint.sh dd83d66f48968bce652bc78ccf2d807949f1725b 


Diff: https://reviews.apache.org/r/65212/diff/2/

Changes: https://reviews.apache.org/r/65212/diff/1-2/


Testing (updated)
-------

Tested with a custom docker image and `support/mesos-tidy.sh` pointing to it.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message