mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 65208: Prevented redundant descriptions when applying reviewboard reviews.
Date Thu, 18 Jan 2018 10:53:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65208/
-----------------------------------------------------------

Review request for mesos, Armand Grillet and Till Toenshoff.


Bugs: MESOS-7979
    https://issues.apache.org/jira/browse/MESOS-7979


Repository: mesos


Description
-------

Reviewboard's `rbt` can be configured to guess field when creating
review requests. With that setting it e.g., uses the first line of a
commit as description, and the remainder as description. If the commit
message has no body it will use the summary as description as well,
leading to redundant information in commit messages which committers
usually remove again manually before committing.

This patch prevents reusing a reviewboard description which is
identical to the summary when synthesising commit message with
`apply_reviews.py`.


Diffs
-----

  support/apply-reviews.py 0ef28cb02bc65acfeb7ea6808f74e1620a8a85c4 


Diff: https://reviews.apache.org/r/65208/diff/1/


Testing
-------

Applied a commit with redundant description; the commit message only contains the reviewboard
URL as body.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message