mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 65166: Added libprocess benchmarks to cmake build setup.
Date Thu, 18 Jan 2018 10:36:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65166/
-----------------------------------------------------------

(Updated Jan. 18, 2018, 11:36 a.m.)


Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.


Repository: mesos


Description
-------

To make sure that `benchmarks` is built as part of the tests we add a
dependency of `libprocess-tests` on `benchmarks` even though no actual
compile- or runtime dependency exists.


Diffs (updated)
-----

  3rdparty/libprocess/src/tests/CMakeLists.txt 8b76cab4d549e18e34aef39863188f37cde74223 


Diff: https://reviews.apache.org/r/65166/diff/3/

Changes: https://reviews.apache.org/r/65166/diff/2-3/


Testing
-------

`make check`
`ninja benchmarks && ./3rdparty/libprocess/src/tests/benchmarks`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message