mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eric Chung <cinchu...@gmail.com>
Subject Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.
Date Thu, 18 Jan 2018 04:24:57 GMT


> On Jan. 5, 2018, 3:23 p.m., Armand Grillet wrote:
> > src/python/cli_new/bootstrap
> > Lines 72 (patched)
> > <https://reviews.apache.org/r/61172/diff/8/?file=1929289#file1929289line72>
> >
> >     This file does not exist, is that normal?

it should...
```
~/mesos/src/python/lib$ git blame requirements-test.in
456a0ac3 (Kevin Klues 2017-07-23 16:21:36 -0700 1) coverage
456a0ac3 (Kevin Klues 2017-07-23 16:21:36 -0700 2) mock
456a0ac3 (Kevin Klues 2017-07-23 16:21:36 -0700 3) pytest
456a0ac3 (Kevin Klues 2017-07-23 16:21:36 -0700 4) pytest-cov
```


> On Jan. 5, 2018, 3:23 p.m., Armand Grillet wrote:
> > src/python/lib/mesos/http.py
> > Lines 72 (patched)
> > <https://reviews.apache.org/r/61172/diff/8/?file=1929291#file1929291line72>
> >
> >     We should do that everywhere in the CLI, this is a useful addition. We could
also use [mypy](http://www.mypy-lang.org/).

that looks pretty cool! we could also migrate to python3 which supports type annotations


- Eric


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61172/#review194862
-----------------------------------------------------------


On Jan. 1, 2018, 1:52 a.m., Eric Chung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61172/
> -----------------------------------------------------------
> 
> (Updated Jan. 1, 2018, 1:52 a.m.)
> 
> 
> Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Part of MESOS-7310, this patch adds the mesos.http and mesos.exceptions
> modules, which provides a Resource class and its descendants for
> abstracting away common operations over http connectioins with JSON
> serialization.
> 
> updated patch according to klueska's recommendations
> 
> 
> addressed comments
> 
> 
> Diffs
> -----
> 
>   src/python/cli_new/bootstrap c84e549e59bc7a07b5b70c24c63bc0c16881e442 
>   src/python/lib/mesos/exceptions.py PRE-CREATION 
>   src/python/lib/mesos/http.py PRE-CREATION 
>   src/python/lib/requirements.in e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
>   src/python/lib/tests/conftest.py PRE-CREATION 
>   src/python/lib/tests/test_exceptions.py PRE-CREATION 
>   src/python/lib/tests/test_http.py PRE-CREATION 
>   src/python/lib/tox.ini 8ad030d2dbf1fb7a04f1eaadb587462b4ef3f054 
>   support/pylint.config f74f553e238553bd6a6c06f4dd888cc5954a33eb 
> 
> 
> Diff: https://reviews.apache.org/r/61172/diff/8/
> 
> 
> Testing
> -------
> 
> install tox
> cd src/python/lib
> tox
> 
> 
> Thanks,
> 
> Eric Chung
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message