mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 64998: Added a SLRP test for CSI plugin restart.
Date Thu, 18 Jan 2018 02:19:23 GMT


> On Jan. 17, 2018, 2:34 a.m., Greg Mann wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Lines 1552-1559 (patched)
> > <https://reviews.apache.org/r/64998/diff/4/?file=1938026#file1938026line1552>
> >
> >     Could this be racy? Since we're not awaiting on the UpdateSlaveMessage containing
the RP resources, is it possible that the first offer the scheduler receives will not contain
any raw disk?

Offers that does not match the `OffersHaveAnyResource(...)` criteria will be declined immediately
by Line 1538. But I should use another set of filters which a long `refuse_seconds` for declining
such offers.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64998/#review195525
-----------------------------------------------------------


On Jan. 10, 2018, 2:33 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64998/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2018, 2:33 a.m.)
> 
> 
> Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
> 
> 
> Bugs: MESOS-8408
>     https://issues.apache.org/jira/browse/MESOS-8408
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The test does the same as the `PublishResources` test, but it kills the
> CSI plugin contaier between each operation.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am bfe9eb1609c71c980c11e7cb0149caf5bdd7ab9b 
>   src/slave/container_daemon.cpp d74fa5105c61a6cadfb2610790e559d387ca13a0 
>   src/slave/container_daemon_process.hpp PRE-CREATION 
>   src/tests/storage_local_resource_provider_tests.cpp bbfe95e9818f25fdd5405db3ad2fe355e023f743

> 
> 
> Diff: https://reviews.apache.org/r/64998/diff/4/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message