mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 65203: Updated the CHANGELOG for 1.5.0 release.
Date Thu, 18 Jan 2018 00:43:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65203/#review195676
-----------------------------------------------------------


Fix it, then Ship it!





CHANGELOG
Line 17 (original), 17 (patched)
<https://reviews.apache.org/r/65203/#comment274944>

    Add a blank line above like you did above?



CHANGELOG
Line 60 (original), 130 (patched)
<https://reviews.apache.org/r/65203/#comment274947>

    I'd move Feature Graduation up before unresolved critical issues



CHANGELOG
Lines 135 (patched)
<https://reviews.apache.org/r/65203/#comment274945>

    I'd combine all capabilities related tickets into one bullet.
    
    This should be similar to the first section that, instead of copying the ticket summary,
we should write full sentenses to explain that that feature is.



CHANGELOG
Lines 142 (patched)
<https://reviews.apache.org/r/65203/#comment274946>

    See my comment above, combine with other capabilities related tickets into one bullet.


- Jie Yu


On Jan. 18, 2018, 12:21 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65203/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2018, 12:21 a.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, Andrew Schwartzmeyer, Benjamin Mahler,
Chun-Hung Hsiao, Gaston Kleiman, Greg Mann, Ilya Pronin, Jie Yu, James Peach, Kapil Arya,
Joseph Wu, Kevin Klues, Neil Conway, Qian Zhang, Till Toenshoff, Vinod Kone, Jiang Yan Xu,
and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated the CHANGELOG for 1.5.0 release.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 078c5d64100d81ce84dbdff4055cdda465e19011 
> 
> 
> Diff: https://reviews.apache.org/r/65203/diff/1/
> 
> 
> Testing
> -------
> 
> N/A.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message