mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 65197: Added some missing email addresses to the contributors list.
Date Thu, 18 Jan 2018 00:23:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65197/#review195670
-----------------------------------------------------------


Ship it!




Hum... so of those email addresses are unfortunate... I suppose it's up to Andrei and Armand
if they want to have those listed.

Everything else looks good though.


docs/contributors.yaml
Lines 84 (patched)
<https://reviews.apache.org/r/65197/#comment274937>

    Looks like there's only one commit with this email:
    ```
    commit 10bdcdc77cad097866055256255d8857dd4fadd3
    Author: Budnik Andrei <abudnik@Budniks-MacBook-Pro.local>
    Date:   Tue May 2 14:20:57 2017 +0200
    
        Added Andrei Budnik to the contributors list.
        
        This closes #209
    ```



docs/contributors.yaml
Lines 118 (patched)
<https://reviews.apache.org/r/65197/#comment274938>

    Only one here too:
    ```
    commit 30f7f3e1965885406d6d3e49348bee7e7d0df9d5
    Author: Armand Grillet <ArmandGrillet@users.noreply.github.com>
    Date:   Mon Feb 6 22:45:43 2017 +0800
    
        Optimized the size of the favicon.
        
        The favicon now only contains two images: 16x16 and 32x32 (for Retina
        displays). The size has reduced from 364 KB to 8 KB.
        
        This closes #202
    ```
    
    And both are Github PRs :|


- Joseph Wu


On Jan. 17, 2018, 4:16 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65197/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2018, 4:16 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Anand Mazumdar, Armand Grillet, Benjamin Hindman,
Greg Mann, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added some missing email addresses to the contributors list.
> 
> 
> Diffs
> -----
> 
>   docs/contributors.yaml 8bfeb89a9dea3de424b454dc0958515bb855f455 
> 
> 
> Diff: https://reviews.apache.org/r/65197/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message