mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 65166: Added libprocess benchmarks to cmake build setup.
Date Wed, 17 Jan 2018 22:13:44 GMT


> On Jan. 17, 2018, 2:12 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/libprocess/src/tests/CMakeLists.txt
> > Lines 98-101 (patched)
> > <https://reviews.apache.org/r/65166/diff/2/?file=1941282#file1941282line98>
> >
> >     Would you rather it be part of the `tests` target explicitly? You could add
it [here](https://github.com/apache/mesos/blob/24a746d85780051d862db0697b63c3c52db4362a/CMakeLists.txt#L60).
> >     
> >     ```
> >     add_custom_target(tests DEPENDS stout-tests libprocess-tests mesos-tests)
> >     ```
> >     
> >     I think it probably makes more sense.

Then again, it's explicitly benchmarks for libprocess, so it also makes sense as a dependency
of `libprocess-tests`. Yeah, nevermind, this is fine I think.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65166/#review195651
-----------------------------------------------------------


On Jan. 17, 2018, 12:42 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65166/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2018, 12:42 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> To make sure that `benchmarks` is built as part of the tests we add a
> dependency of `libprocess-tests` on `benchmarks` even though no actual
> compile- or runtime dependency exists.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/CMakeLists.txt 8b76cab4d549e18e34aef39863188f37cde74223

> 
> 
> Diff: https://reviews.apache.org/r/65166/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> `ninja benchmarks && ./3rdparty/libprocess/src/tests/benchmarks`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message