mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Re: Review Request 63860: Windows: Mapped the Docker network info types.
Date Wed, 17 Jan 2018 20:44:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63860/
-----------------------------------------------------------

(Updated Jan. 17, 2018, 8:44 p.m.)


Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, Jie Yu,
John Kordich, Joseph Wu, and Michael Park.


Changes
-------

fix nolint


Bugs: MESOS-7342
    https://issues.apache.org/jira/browse/MESOS-7342


Repository: mesos


Description
-------

The Network enum in DockerInfo is specific to Linux containers. `HOST`
doesn't exist on Windows and `BRIDGE` is `NAT` on Windows. The current
default docker network setting was always `HOST`, which broke the
Windows docker executor. Now, if a specific network isn't given, the
network mode will default to `HOST` on Linux agents and `NAT` on Windows
agents. Also, `BRIDGE` mode will be translated to `NAT` on Windows.


Diffs (updated)
-----

  src/docker/docker.cpp 722a54ad113fc4e2bb22a8f08e307ab38d5fbfed 


Diff: https://reviews.apache.org/r/63860/diff/10/

Changes: https://reviews.apache.org/r/63860/diff/9-10/


Testing
-------

See https://reviews.apache.org/r/63862/ for test results.


Thanks,

Akash Gupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message