mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 65166: Added libprocess benchmarks to cmake build setup.
Date Wed, 17 Jan 2018 20:42:38 GMT


> On Jan. 17, 2018, 7:58 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/src/tests/CMakeLists.txt
> > Lines 91-93 (patched)
> > <https://reviews.apache.org/r/65166/diff/1/?file=1940269#file1940269line91>
> >
> >     We don't want to build this executable by default, so drop a `EXCLUDE_FROM_ALL`
in here.
> >     
> >     ```
> >     add_executable(
> >       benchmarks EXCLUDE_FROM_ALL
> >       benchmarks.cpp
> >       benchmarks.pb.cc)
> >     ```

Like discussed offline, we would still want to make sure that this target is built at all.
I added a dummy dependency of `libprocess-tests` on `benchmarks` to make sure it is built
as part of e.g., `check`.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65166/#review195631
-----------------------------------------------------------


On Jan. 17, 2018, 9:42 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65166/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2018, 9:42 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> To make sure that `benchmarks` is built as part of the tests we add a
> dependency of `libprocess-tests` on `benchmarks` even though no actual
> compile- or runtime dependency exists.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/CMakeLists.txt 8b76cab4d549e18e34aef39863188f37cde74223

> 
> 
> Diff: https://reviews.apache.org/r/65166/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> `ninja benchmarks && ./3rdparty/libprocess/src/tests/benchmarks`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message