mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 65059: Speeded up SLRP unit tests.
Date Wed, 17 Jan 2018 19:25:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65059/#review195639
-----------------------------------------------------------




src/tests/storage_local_resource_provider_tests.cpp
Line 604 (original), 607 (patched)
<https://reviews.apache.org/r/65059/#comment274901>

    Ah, I'm realizing it would be good to be more consistent with naming here. Other variables
use "slave" instead of "agent", so probably better to just do `slaveFlags` for the flags?


- Greg Mann


On Jan. 10, 2018, 2:32 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65059/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2018, 2:32 a.m.)
> 
> 
> Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
> 
> 
> Bugs: MESOS-8426
>     https://issues.apache.org/jira/browse/MESOS-8426
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch makes all SLRP unit tests to use an allocation interval of
> 50ms and decline offers with filters.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp bbfe95e9818f25fdd5405db3ad2fe355e023f743

> 
> 
> Diff: https://reviews.apache.org/r/65059/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message