mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 63829: Modified Containerizer::remove to allow top-level containers.
Date Wed, 17 Jan 2018 19:24:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63829/
-----------------------------------------------------------

(Updated Jan. 17, 2018, 11:24 a.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Zhitao Li.


Changes
-------

Rebased.


Repository: mesos


Description
-------

This includes two changes:
1) Containerizer::remove no longer CHECKs for a nested container as
   input and accepts standalone containers too.
2) Standalone containers no longer have their runtime directory
   deleted upon exit (which funnily, would prevent the containerizer
   from figuring out that the ContainerID is a standalone).

This change means that, for standalone containers, the caller will
need to explicitly remove the standalone container with the
REMOVE_CONTAINER API.


Diffs (updated)
-----

  src/slave/containerizer/mesos/containerizer.cpp ec39d04e7129a4f8b87166f18d3203dc280c373b

  src/tests/agent_container_api_tests.cpp 618569277545205017320aaf1f3a70e540d35e30 


Diff: https://reviews.apache.org/r/63829/diff/2/

Changes: https://reviews.apache.org/r/63829/diff/1-2/


Testing
-------

Doesn't build at the moment, as the dependent review needs a rebase (due to my earlier changes
:) )


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message