mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 65166: Added libprocess benchmarks to cmake build setup.
Date Wed, 17 Jan 2018 18:58:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65166/#review195631
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/src/tests/CMakeLists.txt
Lines 81-82 (patched)
<https://reviews.apache.org/r/65166/#comment274894>

    Stylistically, we've cut back a bit on these header sections (we could probably revise
the text in the stout/tests CMakeLists).  
    
    It is nice to call out since benchmarks are not normally built.  You could change it to
something like:
    ```
    # LIBPROCESS BENCHMARK TESTS
    ############################
    ```



3rdparty/libprocess/src/tests/CMakeLists.txt
Lines 91-93 (patched)
<https://reviews.apache.org/r/65166/#comment274895>

    We don't want to build this executable by default, so drop a `EXCLUDE_FROM_ALL` in here.
    
    ```
    add_executable(
      benchmarks EXCLUDE_FROM_ALL
      benchmarks.cpp
      benchmarks.pb.cc)
    ```


- Joseph Wu


On Jan. 15, 2018, 3:48 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65166/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2018, 3:48 a.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added libprocess benchmarks to cmake build setup.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/CMakeLists.txt 8b76cab4d549e18e34aef39863188f37cde74223

> 
> 
> Diff: https://reviews.apache.org/r/65166/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> `ninja benchmarks && ./3rdparty/libprocess/src/tests/benchmarks`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message