mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 64848: Updated example frameworks to make use of added flags.
Date Wed, 17 Jan 2018 18:37:00 GMT


> On Jan. 16, 2018, 11:19 p.m., Vinod Kone wrote:
> > src/examples/test_http_framework.cpp
> > Lines 399-401 (original), 401-403 (patched)
> > <https://reviews.apache.org/r/64848/diff/3/?file=1940015#file1940015line401>
> >
> >     hmm. this seems incorrect? how did this compile!?

Dang - that slipped in while rebasing.


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64848/#review195513
-----------------------------------------------------------


On Jan. 15, 2018, 12:29 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64848/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2018, 12:29 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, Kapil Arya,
and Vinod Kone.
> 
> 
> Bugs: MESOS-8357
>     https://issues.apache.org/jira/browse/MESOS-8357
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The example frameworks now consistently rely on a set of common flags
> for parameterizing. This unifies parameter names, descriptions and
> validation for those examples.
> 
> 
> Diffs
> -----
> 
>   src/examples/balloon_framework.cpp 410966e64aa3f146a88c00babaa51b499dd24d36 
>   src/examples/disk_full_framework.cpp d75f769538d17229bdbf332ea7513b1aa8d7c334 
>   src/examples/docker_no_executor_framework.cpp 1fa408d3847d414c23eed8334db8de02e84cf764

>   src/examples/dynamic_reservation_framework.cpp 538fbe8847a1b1dcbfe48ad0e3678797801a12f5

>   src/examples/load_generator_framework.cpp 42867992eba8699cab5b70c62a24b87446139406

>   src/examples/long_lived_framework.cpp 943160d5a42e02cf05fe92999233ce2e792849fd 
>   src/examples/no_executor_framework.cpp 972ef777cec07d1030af208daef69ebe606d071e 
>   src/examples/persistent_volume_framework.cpp 71db39d7743d31ea34c2aed579d7a1ef2ed95687

>   src/examples/test_framework.cpp acf1faf1523c8c03483dfafbc8f8e245322527e4 
>   src/examples/test_http_framework.cpp 482f65efc15a7bac52c33a57b2b876191249410a 
> 
> 
> Diff: https://reviews.apache.org/r/64848/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message