mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 62447: Reverted usage of `-isystem` flag.
Date Wed, 17 Jan 2018 16:10:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62447/
-----------------------------------------------------------

(Updated Jan. 17, 2018, 4:10 p.m.)


Review request for mesos, Benjamin Bannier and Till Toenshoff.


Changes
-------

Rebased onto latest master.


Summary (updated)
-----------------

Reverted usage of `-isystem` flag.


Repository: mesos


Description (updated)
-------

This flag breaks the build of mesos against system libraries
installed under /usr, because it generates a command line
of `-isystem /usr/include`, which is explicitly not supported
by gcc. See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129


Diffs (updated)
-----

  3rdparty/CMakeLists.txt 579aed83fc5c9cee17cf9b4b289a91705f64ceda 
  configure.ac 59292885b506e9b6fab14107174db11739a587b8 


Diff: https://reviews.apache.org/r/62447/diff/3/

Changes: https://reviews.apache.org/r/62447/diff/2-3/


Testing
-------


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message