mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 62444: Added UNREACHABLE() macro to __cxa_pure_virtual.
Date Wed, 17 Jan 2018 16:07:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62444/
-----------------------------------------------------------

(Updated Jan. 17, 2018, 4:07 p.m.)


Review request for mesos, Benjamin Bannier and Till Toenshoff.


Changes
-------

Rebased onto latest master.


Summary (updated)
-----------------

Added UNREACHABLE() macro to __cxa_pure_virtual.


Repository: mesos


Description
-------

The function __cxa_pure_virtual must not return,
but newer versions of clang detect that the expansion
of the RAW_LOG() macro contains returning code paths
for arguments other than FATAL.


Diffs (updated)
-----

  src/logging/logging.cpp 19dba7faac7f2307e5dfdf15f64849f643b19129 


Diff: https://reviews.apache.org/r/62444/diff/2/

Changes: https://reviews.apache.org/r/62444/diff/1-2/


Testing
-------


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message