mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 62160: Fixed stout build with newer boost versions.
Date Wed, 17 Jan 2018 16:06:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62160/
-----------------------------------------------------------

(Updated Jan. 17, 2018, 4:06 p.m.)


Review request for mesos, Benjamin Bannier and Till Toenshoff.


Changes
-------

Rebased onto latest master.


Summary (updated)
-----------------

Fixed stout build with newer boost versions.


Repository: mesos


Description
-------

Starting from Boost 1.62, Boost.Variant added additional
compile-time checks to its constructors to fix this
issue: https://svn.boost.org/trac10/ticket/11602

However, this breaks some places in stout which try
to access a derived class from a variant holding the
base class.


Diffs (updated)
-----

  3rdparty/stout/include/stout/json.hpp 4f9ea1b34537026af80edd97fa0b3ae1a3dfa862 
  3rdparty/stout/include/stout/protobuf.hpp 01d758143773ca627f078f0a657a23e5d81a653b 
  3rdparty/stout/tests/json_tests.cpp adaa343faf3b557ad483675318b22eb90b1eeb52 


Diff: https://reviews.apache.org/r/62160/diff/3/

Changes: https://reviews.apache.org/r/62160/diff/2-3/


Testing
-------


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message