mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 63661: Updated tests to use `createCallSubscribe`.
Date Wed, 17 Jan 2018 15:33:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63661/#review195592
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/mesos.hpp
Lines 2144-2145 (patched)
<https://reviews.apache.org/r/63661/#comment274856>

    Why not a on-liner?
    ```
    call.mutable_subscribe()->mutable_framework_info()->CopyFrom(frameworkInfo);
    ```


- Alexander Rukletsov


On Nov. 8, 2017, 10:46 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63661/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2017, 10:46 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-8094
>     https://issues.apache.org/jira/browse/MESOS-8094
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated all the tests that send v1 API SUBSCRIBE calls to use the
> `createCallSubscribe` test helper.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp fb45879310faf7edc7d101be206d49de89819c18 
>   src/tests/mesos.hpp 16c75bb0ca570dfb7089743344cf38acdb517705 
>   src/tests/slave_authorization_tests.cpp 4ba0b8e96614a2df0daec576c08fe02462ccaa27 
>   src/tests/slave_recovery_tests.cpp 641fc6e82be19bdea55d35ec8f34a862de58489e 
>   src/tests/slave_tests.cpp 59e3065ad9aadbd90cdfd32e830b433b88d6de86 
> 
> 
> Diff: https://reviews.apache.org/r/63661/diff/3/
> 
> 
> Testing
> -------
> 
> ```
> $ make check
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message