mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 65162: Removed some redundant `get` calls.
Date Wed, 17 Jan 2018 12:22:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65162/#review195555
-----------------------------------------------------------



PASS: Mesos patch 65162 was successfully built and tested.

Reviews applied: `['65160', '65161', '65162']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65162

- Mesos Reviewbot Windows


On Jan. 15, 2018, 10:09 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65162/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2018, 10:09 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed some redundant `get` calls.
> 
> 
> Diffs
> -----
> 
>   src/appc/spec.cpp fc5e24ee5a459522a7a2dc52b4f168c4386b0642 
>   src/authentication/cram_md5/auxprop.cpp 8a20d5bd2d943faa10d2920f76756fb9527075d8 
>   src/cli/execute.cpp 6e626893a64dc07ac9a5f9a5c31e680cb80938fe 
>   src/common/command_utils.cpp c50be7608df3a7e0a6a9d0bb46525a3cbd025bee 
>   src/common/http.cpp 728fc554917ed031f9cb3d811fbbc064307b3e32 
>   src/common/parse.hpp 212d6406a16f5ffd0494197dc44271629dc5ba3b 
>   src/common/protobuf_utils.cpp fda13072743d57d29cdf7ac3c76c0d42a8d36116 
>   src/common/recordio.hpp c58bb14866a3ec3841b09d2e96bb16af20a2e6fd 
>   src/credentials/credentials.hpp c790793c7ea5ed384bdb397bfc1592b8fd1ff327 
>   src/docker/docker.cpp 722a54ad113fc4e2bb22a8f08e307ab38d5fbfed 
>   src/docker/spec.cpp 538cf1883d0dbf953ab5017d9b7d54a68ee72c73 
>   src/executor/executor.cpp 1c972d92984a15d12466e3dd229b16fa60e21ebb 
>   src/files/files.cpp 324b4bcf0ef53931fa7ef9b7a891b160564705ff 
>   src/hook/manager.cpp c659de5418881a77d89e6c579152614c2b47592b 
>   src/internal/evolve.cpp 7758c9b93ad41b45b941c0de8c2b1008fbc4e50d 
>   src/launcher/executor.cpp 050f5a057f360873e2b4738b126289bcd1bd0c7f 
>   src/launcher/fetcher.cpp 7fc69fe22b362bf0d13d629829a2c6a9de4f1579 
>   src/linux/cgroups.cpp cdd0f40ec5748b909e529f21b15523122bf90d41 
>   src/linux/fs.cpp 94e78df0336f63c58eb3d4da0d7fe45dfcb493c1 
>   src/linux/ns.cpp 446640705b7c060776ed87655fb17509865cd335 
>   src/local/local.cpp ba1bcf21df70bba520f3f9b671bb57d498335c44 
>   src/log/catchup.cpp 79cc18c4311d14c82801d856681171c5f1ce95c8 
>   src/log/consensus.cpp f766015fac44cce173ec7ef3f5dd3f0ac9e03ef5 
>   src/log/replica.cpp c86a609f7fc7fcfd42761180c464c383961a986e 
>   src/log/tool/benchmark.cpp b939e26aceafc47015f3f0a93c5ce6a1f8aca605 
>   src/log/tool/initialize.cpp c0f85439a87f939bad076733fbc9e12b60f5b8f9 
>   src/log/tool/read.cpp 50fb0209a67251eb6ae320f3cd6dcd7ba11bdd99 
>   src/master/allocator/mesos/hierarchical.cpp f33ff767dcb93556beb696c96f8cfc17baccb05e

>   src/master/contender/contender.cpp ea7453d1d4753a77c6161ec0b812bb0bf38483dd 
>   src/master/contender/zookeeper.cpp 64fbb3adbb0812f430fe152550a8a8707c0fed8f 
>   src/master/detector/detector.cpp 9d2e8c4d3fb342fe4ada01628b33b7c470ba63b6 
>   src/master/detector/zookeeper.cpp 1cab567615d756ebd1a40549718c47b642cf0eb8 
>   src/master/http.cpp cae67b8e905a11b0825399aeb540ca259b8938ed 
>   src/master/main.cpp f65ce637d77ce183f83b70dce6da8d0b4b8b8e71 
>   src/master/master.hpp 3d5180b8028b2a15ad111f91863e77747b362593 
>   src/master/master.cpp 465336d33008a848df063d4295416eb91f7bb44f 
>   src/master/quota_handler.cpp 37d43e1d9473b750ffd76701472e7448aa61c8c3 
>   src/master/registrar.cpp aabce22e4b06826e4452c61c27ebdd702b1e47bc 
>   src/master/validation.cpp f0b86775b7919ba6aa4a73038edb78a0adca68f4 
>   src/master/weights_handler.cpp 59104a85d2b74cf42461b02d85101c7c751f706c 
>   src/resource_provider/http_connection.hpp add5acc47aaf79b50ef9a7bd1e17ff0db5b95439

>   src/resource_provider/registrar.cpp 3e6b64bae1c56d3ca27edd0debac428b47f17d04 
>   src/sched/sched.cpp 613a33b7d3150ad851af674e989a84b3899f2d69 
>   src/scheduler/scheduler.cpp 07d2b37e0874edd27365719705272568d386323b 
>   src/slave/container_loggers/lib_logrotate.cpp bc13e6a52460d4607873c4b0022165038051bc51

>   src/slave/containerizer/containerizer.cpp fa1d24a56380dd34ed15d3d12e610dfcfe4c56d6

>   src/slave/containerizer/docker.cpp 6d9c598a5e60a01dbb3e10108aeed6c650338664 
>   src/slave/containerizer/fetcher.cpp 8b26e882eced9478ffdc6b2dcbc0a5796c5c3ce2 
>   src/slave/containerizer/mesos/containerizer.cpp f69f65a5033ce0c1fa2fe9591d8c6bbada5e09fb

>   src/slave/containerizer/mesos/io/switchboard.cpp 4ef640616d69b91c225206444737a40f9571da55

>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpu.cpp fc763bd7834567882146ad25e0266b1183154dc3

>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpuacct.cpp ffa0d3b0e6f3d8a1f55c88d61f20cff426119e20

>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp 99e824ae5ccafbad5f404f48461783ff05b35646

>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp af1d477324e498c2627f6787c8ae7e9e8e3e8fd5

>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 7f2708c1f19102ec0c68674af21100443c383b96

>   src/slave/containerizer/mesos/isolators/volume/image.cpp 8ca3d55d5792ed1cfc8e49df40587ac2abc83fec

>   src/slave/containerizer/mesos/launcher.cpp 0e37cd256563c8d6ca2d5bc522246f7ee10c337d

>   src/slave/containerizer/mesos/linux_launcher.cpp c2e319894874e628beda6dc305462af0c274fd7b

>   src/slave/containerizer/mesos/provisioner/appc/cache.cpp 0cd444b93528545bd01e3b59ba77db2e3a341029

>   src/slave/containerizer/mesos/provisioner/backends/bind.cpp d6cdc93128c3663fae3cdf77b9c5c373bc3d662d

>   src/slave/containerizer/mesos/provisioner/backends/copy.cpp 69faa03f306032447fa33ae2de8a55fee9c2ed41

>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 168f786248ebdd6ff9855fe4998b27b169611f81

>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 7b6ddb18b2d2917cc6763aed7f830534ce579cda

>   src/slave/main.cpp f38fec6028ade0e0a51fd2cce7470c5c36e66396 
>   src/slave/qos_controllers/load.cpp a241ef3a94cf35e53273a1e47f8ede589fd8b580 
>   src/slave/slave.cpp 1672c06894c25e7120bb8a1da15f7d6432eb5954 
>   src/slave/validation.cpp 0c2ccda177734cf3c47c0346ed34d20d58e7d932 
>   src/state/in_memory.cpp f6852e041b64342e7755b00eed3dcb379f137d19 
>   src/state/leveldb.cpp 50d0c7c02f96dfd7987d6e31fafe40c91f651ae1 
>   src/state/log.cpp 48d10373c0552722b2f4228b49aab113270e07f8 
>   src/state/zookeeper.cpp f992fb948819b4f0b2c1fc65c7a5ebd2ca8f61e2 
>   src/tests/api_tests.cpp 6faefc92318c2db0e611d60f187738d0cbb269ff 
>   src/tests/cluster.cpp 568c9c7eda9d69e85bc32ce3259548b348ed9f25 
>   src/tests/containerizer/cni_isolator_tests.cpp 364e2e30a76daff7eaa2b2acaada05b4124ef7a4

>   src/tests/containerizer/docker_containerizer_tests.cpp d1e657050d623ad0412208b3aa3e3101e3654e99

>   src/tests/containerizer/environment_secret_isolator_tests.cpp 9728587150064529eb94a48485ff3076f4464f33

>   src/tests/default_executor_tests.cpp 065eae665db08b39aef70325cebc2753beb30d96 
>   src/tests/environment.cpp 13a4c9514fcd3016fe623c597decd067457e86cd 
>   src/tests/health_check_tests.cpp 1893c85169f5e94e164434b93e6a24268224225d 
>   src/tests/master_maintenance_tests.cpp 2a0625873b4f9b6350c14e8304a8d6fbd6a45e6b 
>   src/tests/master_tests.cpp 0edf22431aad85945aeb808a05f11e0bd832bccf 
>   src/tests/mesos.hpp 16c75bb0ca570dfb7089743344cf38acdb517705 
>   src/tests/scheduler_http_api_tests.cpp 02cfe54375fdda6ae11cbe31f5c6eed920e5d7f6 
>   src/tests/slave_authorization_tests.cpp f3848db2e6040bae12c1d157df7e11892a257fb4 
>   src/tests/slave_tests.cpp 59e3065ad9aadbd90cdfd32e830b433b88d6de86 
>   src/uri/fetchers/copy.cpp 17f69bea4dd7040b70283dc6852c1bdc9ff27406 
>   src/uri/fetchers/curl.cpp f34daf2bc1f3fef74548e04ad332e3a627636bfd 
>   src/uri/fetchers/docker.cpp 91db13b29477df81bbbdee55672c743c77fb3935 
>   src/usage/usage.cpp 01c29f0934e0f740a8fdd5eadbf9a61837463a3a 
>   src/watcher/whitelist_watcher.cpp 3a556c556911a9c7c24539b9ecc031722372492a 
>   src/zookeeper/contender.cpp fa49647aa3591689a13dbfb55a41096cc3d002da 
> 
> 
> Diff: https://reviews.apache.org/r/65162/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> These changes were made automatically with https://github.com/mesos/clang-tools-extra/pull/13
with only a few minor additions in surrounding code.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message