mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 64823: Documented the change in the Protobuf requirement.
Date Wed, 17 Jan 2018 11:31:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64823/#review195552
-----------------------------------------------------------


Fix it, then Ship it!




Let's make sure to land this in `1.5.0-rc1` in addition to `master`.


CHANGELOG
Lines 14 (patched)
<https://reviews.apache.org/r/64823/#comment274787>

    I'd move this section to the bottom. Maybe we could use a more generic title, e.g., `Changes
to dependencies`.


- Benjamin Bannier


On Dec. 23, 2017, 1:21 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64823/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2017, 1:21 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Documented the change in the Protobuf requirement.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 179b53b0568e4d993553f5cdb13668d96aa400d0 
>   docs/upgrades.md f2eb5a94d67b44a02d355981a673bd4ef5129653 
> 
> 
> Diff: https://reviews.apache.org/r/64823/diff/1/
> 
> 
> Testing
> -------
> 
> N/A
> 
> The requirement is checked in https://reviews.apache.org/r/64822/.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message