mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 65126: Added a resource provider test case.
Date Wed, 17 Jan 2018 11:15:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65126/#review195548
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/master_tests.cpp
Lines 8641 (patched)
<https://reviews.apache.org/r/65126/#comment274778>

    Remove one line.



src/tests/master_tests.cpp
Lines 8694 (patched)
<https://reviews.apache.org/r/65126/#comment274781>

    We need to assert here.



src/tests/master_tests.cpp
Lines 8731 (patched)
<https://reviews.apache.org/r/65126/#comment274782>

    `ASSERT_FALSE`


- Benjamin Bannier


On Jan. 16, 2018, 12:04 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65126/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2018, 12:04 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8445
>     https://issues.apache.org/jira/browse/MESOS-8445
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a resource provider test case.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 0edf22431aad85945aeb808a05f11e0bd832bccf 
> 
> 
> Diff: https://reviews.apache.org/r/65126/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message