mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 64969: Added an performance benchmark for master `Getstate` v1 api.
Date Wed, 17 Jan 2018 01:38:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64969/#review195526
-----------------------------------------------------------


Fix it, then Ship it!




s/Getstate/GetState/ in the summary

Just some minor comments here, I'll get these taken care of and push this shortly!


src/tests/master_benchmarks.cpp
Lines 360 (patched)
<https://reviews.apache.org/r/64969/#comment274729>

    '/state'



src/tests/master_benchmarks.cpp
Lines 362 (patched)
<https://reviews.apache.org/r/64969/#comment274728>

    GetState here and elsewhere



src/tests/master_benchmarks.cpp
Lines 404 (patched)
<https://reviews.apache.org/r/64969/#comment274719>

    We don't log with a trailing period, we took this decision in the past because it's hard
to figure out who should be adding the period in the cases where logging messages are being
composed together.
    
    s/.//



src/tests/master_benchmarks.cpp
Lines 435 (patched)
<https://reviews.apache.org/r/64969/#comment274720>

    Maybe just use single quotes here? That would be more consistent with the rest of our
logging



src/tests/master_benchmarks.cpp
Lines 458 (patched)
<https://reviews.apache.org/r/64969/#comment274722>

    s/){/) {/
    
    I think we still mostly use foreach, although at some point we probably want to move to
range based for loops:
    
    foreach (ContentType contentType, contentTypes) {



src/tests/master_benchmarks.cpp
Lines 471 (patched)
<https://reviews.apache.org/r/64969/#comment274727>

    response->status



src/tests/master_benchmarks.cpp
Lines 474 (patched)
<https://reviews.apache.org/r/64969/#comment274725>

    response->body



src/tests/master_benchmarks.cpp
Lines 477 (patched)
<https://reviews.apache.org/r/64969/#comment274724>

    EXPECT_EQ could be used here since the test can proceed



src/tests/master_benchmarks.cpp
Lines 479 (patched)
<https://reviews.apache.org/r/64969/#comment274721>

    'master::call::GetState'?



src/tests/master_benchmarks.cpp
Lines 480 (patched)
<https://reviews.apache.org/r/64969/#comment274723>

    alignment


- Benjamin Mahler


On Jan. 17, 2018, 1:29 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64969/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2018, 1:29 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Michael Park, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-8344
>     https://issues.apache.org/jira/browse/MESOS-8344
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test is based on the MasterFailover benchmark which
> currently lacks things like executor. It is possible
> to add these when needed.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_benchmarks.cpp 7d69588b3a4090ad1a755b592d2f8756ad6dff9e 
> 
> 
> Diff: https://reviews.apache.org/r/64969/diff/3/
> 
> 
> Testing
> -------
> 
> Example output from optimized build:
> 
> [ RUN      ] AgentFrameworkTaskCountContentType/MasterStateQuery_BENCHMARK_Test.Getstate/0
> Test setup: 1000 agents with a total of 10000 running tasks and 10000 completed tasks.
> v0 "/state" query response took 367.331953ms
> v1 Getstate application/x-protobuf query response took 312.803708ms
> v1 Getstate application/json query response took 732.807684ms
> [       OK ] AgentFrameworkTaskCountContentType/MasterStateQuery_BENCHMARK_Test.Getstate/0
(8105 ms)
> [ RUN      ] AgentFrameworkTaskCountContentType/MasterStateQuery_BENCHMARK_Test.Getstate/1
> Test setup: 10000 agents with a total of 100000 running tasks and 100000 completed tasks.
> v0 "/state" query response took 3.591473849secs
> v1 Getstate application/x-protobuf query response took 3.661784437secs
> v1 Getstate application/json query response took 6.905652075secs
> [       OK ] AgentFrameworkTaskCountContentType/MasterStateQuery_BENCHMARK_Test.Getstate/1
(83974 ms)
> [ RUN      ] AgentFrameworkTaskCountContentType/MasterStateQuery_BENCHMARK_Test.Getstate/2
> Test setup: 20000 agents with a total of 200000 running tasks and 200000 completed tasks.
> v0 "/state" query response took 7.049141398secs
> v1 Getstate application/x-protobuf query response took 8.918444916secs
> v1 Getstate application/json query response took 13.443727676secs
> [       OK ] AgentFrameworkTaskCountContentType/MasterStateQuery_BENCHMARK_Test.Getstate/2
(174468 ms)
> [ RUN      ] AgentFrameworkTaskCountContentType/MasterStateQuery_BENCHMARK_Test.Getstate/3
> Test setup: 40000 agents with a total of 400000 running tasks and 400000 completed tasks.
> v0 "/state" query response took 14.37652117secs
> v1 Getstate application/x-protobuf query response took 15.759739083secs
> v1 Getstate application/json query response took 29.837744733secs
> [       OK ] AgentFrameworkTaskCountContentType/MasterStateQuery_BENCHMARK_Test.Getstate/3
(368313 ms)
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message