mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 65114: Updated C++ Style Guide.
Date Tue, 16 Jan 2018 20:18:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65114/
-----------------------------------------------------------

(Updated Jan. 16, 2018, 12:18 p.m.)


Review request for mesos, Benjamin Mahler, Greg Mann, Jie Yu, and Joseph Wu.


Repository: mesos


Description
-------

Added three missing style notes:

* Use of `::` for global namespace
* Put `template <typename T>` on own line
* Prefer `->foo()` to `.get().foo()`


Diffs (updated)
-----

  docs/c++-style-guide.md ef80c868fd3f366c998bc33c9f8a664dc35b0336 


Diff: https://reviews.apache.org/r/65114/diff/2/

Changes: https://reviews.apache.org/r/65114/diff/1-2/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message