mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 65147: Windows: Fixed docker executor `PATH` variable.
Date Tue, 16 Jan 2018 20:05:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65147/
-----------------------------------------------------------

(Updated Jan. 16, 2018, 12:05 p.m.)


Review request for mesos, Akash Gupta, Gilbert Song, Jie Yu, and Joseph Wu.


Bugs: MESOS-8443
    https://issues.apache.org/jira/browse/MESOS-8443


Repository: mesos


Description (updated)
-------

The `docker` executable is not usually installed in
`os::host_default_path()` on Windows, so the Executor cannot find it.
Now, before launching the Executor, the Agent finds the directory
containing `docker` and prepends it to the `PATH` given to the Executor
so that both the Executor and Agent use the same `docker`.


Diffs (updated)
-----

  src/slave/containerizer/docker.cpp b42fe1f4b7151ee5cb1d7c680c7c0237882bd4bb 


Diff: https://reviews.apache.org/r/65147/diff/2/

Changes: https://reviews.apache.org/r/65147/diff/1-2/


Testing
-------

Tested on Windows 10, all passed.

Integration tested (courtsey of Akash) that Docker containers can be launched without manually
fixing the path.

`make check` on CentOS 7, all passed.

NOTE: This is Windows-only, and replaces [#64570](https://reviews.apache.org/r/64570/). Joseph
and I worked out this approach to prevent a regression for Mesos customers moving from `1.4`
to `1.5`; see MESOS-8443 for details.


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message