mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 65147: Windows: Fixed docker executor `PATH` variable.
Date Tue, 16 Jan 2018 19:45:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65147/#review195492
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/docker.cpp
Lines 1470-1471 (patched)
<https://reviews.apache.org/r/65147/#comment274692>

    We will consider removing the `#ifdef` in future, as other platforms may benefit from
being pointed to the same `docker` in both Agent and Executor (there is a chance that the
cleaned path results in using a different `docker`, if multiple `docker`s are installed).



src/slave/containerizer/docker.cpp
Lines 1477 (patched)
<https://reviews.apache.org/r/65147/#comment274693>

    On the off-chance that `docker` is installed in the `host_default_path()`, this `PATH`
modification should **pre**-pend the docker path, rather than append it.


- Joseph Wu


On Jan. 13, 2018, 6:01 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65147/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2018, 6:01 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Gilbert Song, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-8443
>     https://issues.apache.org/jira/browse/MESOS-8443
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `docker` isn't always installed in `os::host_default_path()` on Windows,
> so the docker executor cannot find it. Now, before launching the
> executor, the mesos agent finds `docker`'s parent directory and appends
> that to `PATH`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp b42fe1f4b7151ee5cb1d7c680c7c0237882bd4bb 
> 
> 
> Diff: https://reviews.apache.org/r/65147/diff/1/
> 
> 
> Testing
> -------
> 
> Tested on Windows 10, all passed.
> 
> Integration tested (courtsey of Akash) that Docker containers can be launched without
manually fixing the path.
> 
> `make check` on CentOS 7, all passed.
> 
> NOTE: This is Windows-only, and replaces [#64570](https://reviews.apache.org/r/64570/).
Joseph and I worked out this approach to prevent a regression for Mesos customers moving from
`1.4` to `1.5`; see MESOS-8443 for details.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message