mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 65145: Fixed use of `os::which`.
Date Tue, 16 Jan 2018 19:37:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65145/#review195489
-----------------------------------------------------------


Ship it!




Ship It!

- Joseph Wu


On Jan. 13, 2018, 6 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65145/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2018, 6 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Gilbert Song, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-8225
>     https://issues.apache.org/jira/browse/MESOS-8225
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Because `os::which` was added to its own header, all uses of it now need
> to include said header.
> 
> In `tests/environment.cpp`, instead of using `os::system("which foo")`,
> we now use `os::which("foo")` to be compatible with Windows.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp ba9e20c16841bfaa2a5c72d449a2da1a637b71df

>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 61de16ba7f1b0ba80663a8544baa98fe36302df0

>   src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp
de64d6572c59da22dff528b308b4a4b0e9be9d2f 
>   src/slave/containerizer/mesos/launch.cpp c45a038f191d7ddc536bb1ffc58532df90aff153 
>   src/tests/environment.cpp 72bd621f02f97ea5fd553f3dc0bd52adb8ddee8f 
> 
> 
> Diff: https://reviews.apache.org/r/65145/diff/1/
> 
> 
> Testing
> -------
> 
> This looks bigger than it is because `#include <stout/os/which.hpp>` was added
to each file that used `os::which`. Logic change is constrained to a test file.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message