mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 65144: Ported `os::which` to Windows.
Date Tue, 16 Jan 2018 18:35:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65144/#review195475
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Jan. 14, 2018, 2:01 a.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65144/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2018, 2:01 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Gilbert Song, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-8225
>     https://issues.apache.org/jira/browse/MESOS-8225
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Because `os::which` still lived in `posix/os.hpp`, it was refactored
> into its own `os/which.hpp` (which the respective `os/posix/which.hpp`
> and `os/windows/which.hpp`. Consumers of this will need additionally
> include the new header, instead of just `os.hpp`.
> 
> The differences in implementation from POSIX to Windows are:
> 
> * Split the `PATH` on `;` not `:`.
> * Also loop over `PATHEXT` because executables on Windows end with one
>   of a set of extensions.
> * Removed the permissions check because it is not applicable on
>   Windows (instead, an executable ends with an extension in `PATHEXT`,
>   see above).
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/Makefile.am e5f11048af4ced8e8312d5c77fc3dde94f8e7012 
>   3rdparty/stout/include/stout/os/posix/which.hpp PRE-CREATION 
>   3rdparty/stout/include/stout/os/which.hpp PRE-CREATION 
>   3rdparty/stout/include/stout/os/windows/which.hpp PRE-CREATION 
>   3rdparty/stout/include/stout/posix/os.hpp 7427bd792368fbacafb23593dfb9213618fdcddf

>   3rdparty/stout/tests/os_tests.cpp de4107718cfa45f3275693a7dd59b2f52b0ced7d 
> 
> 
> Diff: https://reviews.apache.org/r/65144/diff/1/
> 
> 
> Testing
> -------
> 
> This looks bigger than it is because the implementation was moved (cut/paste/clang-format)
out of `posix/os.hpp` into `os/posix/which.hpp`, next patch adds header to all files using
`os::which`.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message