mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@apache.org>
Subject Re: Review Request 64978: Made task's volume directory visible in the /files endpoints.
Date Tue, 16 Jan 2018 17:24:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64978/#review195462
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/slave.hpp
Lines 837-838 (patched)
<https://reviews.apache.org/r/64978/#comment274638>

    can you just take `const Task&` as argument like you did for `detach`?



src/slave/slave.cpp
Line 5911 (original)
<https://reviews.apache.org/r/64978/#comment274639>

    this should have been in the previous review.



src/slave/slave.cpp
Lines 9162 (patched)
<https://reviews.apache.org/r/64978/#comment274635>

    I would move this comment to the header where the function is declared.



src/slave/slave.cpp
Lines 9183 (patched)
<https://reviews.apache.org/r/64978/#comment274637>

    shouldn't this be a CHECK too like you did for `detach` below?



src/slave/slave.cpp
Lines 9219 (patched)
<https://reviews.apache.org/r/64978/#comment274636>

    ditto. move comment to the header.


- Vinod Kone


On Jan. 15, 2018, 6:21 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64978/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2018, 6:21 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-8279
>     https://issues.apache.org/jira/browse/MESOS-8279
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In MESOS-7225, we made a task can access any volumes specified in its
> disk resources from its own sandbox by introducing a workaround to the
> default executor, i.e., add a `SANDBOX_PATH` volume with type `PARENT`
> to the corresponding nested container. It will be translated into a bind
> mount in the nested container's mount namespace, thus not visible in the
> host mount namespace, that means the task's volume directory can not be
> visible in Mesos UI since it operates in the host mount namespace.
> 
> In this patch, to make the task's volume directory visible in Mesos UI,
> we attached the executor's volume directory to it, so when users browse
> task's volume directory in Mesos UI, what they actually browse is the
> executor's volume directory. Note when calling `Files::attach()`, the
> third argument `authorized` is not specified, that is because it is
> already specified when we do the attach for the executor's sandbox and
> it is also applied to the executor's tasks.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp ef0eae21af811cc09f43cd1d4c4ccc0c33cbeb39 
>   src/slave/slave.cpp aeb0fdaeda78f26de2ec790735bfa88c5be72850 
> 
> 
> Diff: https://reviews.apache.org/r/64978/diff/4/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message